From: Dan Carpenter <error27@gmail.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sundar Iyer <sundar.iyer@stericsson.com>,
linux-input@vger.kernel.org
Subject: Re: [patch] input/tc3589x: fix compile error
Date: Wed, 5 Jan 2011 11:20:16 +0300 [thread overview]
Message-ID: <20110105082016.GD24847@bicker> (raw)
In-Reply-To: <AANLkTinmhwwzMn9Xnfv+_jE46CjvtaRVY3X8Uvwt4q7V@mail.gmail.com>
On Wed, Jan 05, 2011 at 02:01:01AM +0100, Linus Walleij wrote:
> 2011/1/4 Dan Carpenter <error27@gmail.com>:
>
> > There was a semi-colon missing and it broke the compile.
>
> How come my setup compiles then... Oh well, probably a more
> forgiving compiler.
The only explanation I can think of is that you're compiling the driver
into the kernel instead of as a module? A lot of people like to have
their keyboard compiled in instead of loaded later.
You could try a "make drivers/input/keyboard/tc3589x-keypad.i" and look
at the precompiled code.
regards,
dan carpenter
> Applied it.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2011-01-05 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 11:08 [patch] input/tc3589x: fix compile error Dan Carpenter
2011-01-05 1:01 ` Linus Walleij
2011-01-05 8:20 ` Dan Carpenter [this message]
2011-01-05 10:55 ` Linus Walleij
2011-01-07 10:12 ` Linus Walleij
2011-01-07 17:45 ` Dmitry Torokhov
2011-01-07 19:50 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2011-01-07 19:47 [PATCH] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105082016.GD24847@bicker \
--to=error27@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.