From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 3/5]add metadata_readahead ioctl in vfs Date: Wed, 5 Jan 2011 10:09:20 +0100 Message-ID: <201101051009.20591.arnd@arndb.de> References: <1294119637.1949.368.camel@sli10-conroe> <201101041051.13979.arnd@arndb.de> <1294193496.1949.378.camel@sli10-conroe> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1294193496.1949.378.camel@sli10-conroe> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shaohua Li Cc: "linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chris Mason , Christoph Hellwig , Andrew Morton , Arjan van de Ven , "Yan, Zheng" , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" List-Id: linux-api@vger.kernel.org On Wednesday 05 January 2011 03:11:36 Shaohua Li wrote: > > Did you notice the comment above the function? ;-) > > > > You should really add the new ioctls to compat_sys_ioctl, not > > to the COMPATIBLE_IOCTL() list, in order to make the behavior > > consistent between 32 and 64 bit user space. The main difference > > is that all ioctl commands that are hardcoded in the functions > > get called before trying to call the file system specific > > .ioctl method. > Thanks, fixed them. The patch you posted still uses COMPATIBLE_IOCTL. Wrong patch? Arnd