From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Dmitry Eremin-Solenikov
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit
Date: Wed, 5 Jan 2011 12:17:31 +0000 [thread overview]
Message-ID: <20110105121731.GG817@trinity.fluff.org> (raw)
In-Reply-To: <1294193110-23958-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Jan 05, 2011 at 05:05:05AM +0300, Dmitry Eremin-Solenikov wrote:
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Please write a reasonable commit message, a null or almost empty commit
message is simply unnaceptable. Please see the Documentation/SubmittingPatches
or ask more about how to write good commit messages.
Also, see Uwe's reply for a good example of how to write a commit message.
> -static int __exit i2c_pxa_remove(struct platform_device *dev)
> +static int __devexit i2c_pxa_remove(struct platform_device *dev)
> {
> struct pxa_i2c *i2c = platform_get_drvdata(dev);
>
> @@ -1169,7 +1169,7 @@ static const struct dev_pm_ops i2c_pxa_dev_pm_ops = {
>
> static struct platform_driver i2c_pxa_driver = {
> .probe = i2c_pxa_probe,
> - .remove = __exit_p(i2c_pxa_remove),
> + .remove = __devexit_p(i2c_pxa_remove),
> .driver = {
> .name = "pxa2xx-i2c",
> .owner = THIS_MODULE,
Right, I think this should fix any hotplug problems that you have.
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
WARNING: multiple messages have this Message-ID (diff)
From: ben-i2c@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit
Date: Wed, 5 Jan 2011 12:17:31 +0000 [thread overview]
Message-ID: <20110105121731.GG817@trinity.fluff.org> (raw)
In-Reply-To: <1294193110-23958-1-git-send-email-dbaryshkov@gmail.com>
On Wed, Jan 05, 2011 at 05:05:05AM +0300, Dmitry Eremin-Solenikov wrote:
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: linux-i2c at vger.kernel.org
> Cc: Ben Dooks <ben-linux@fluff.org>
Please write a reasonable commit message, a null or almost empty commit
message is simply unnaceptable. Please see the Documentation/SubmittingPatches
or ask more about how to write good commit messages.
Also, see Uwe's reply for a good example of how to write a commit message.
> -static int __exit i2c_pxa_remove(struct platform_device *dev)
> +static int __devexit i2c_pxa_remove(struct platform_device *dev)
> {
> struct pxa_i2c *i2c = platform_get_drvdata(dev);
>
> @@ -1169,7 +1169,7 @@ static const struct dev_pm_ops i2c_pxa_dev_pm_ops = {
>
> static struct platform_driver i2c_pxa_driver = {
> .probe = i2c_pxa_probe,
> - .remove = __exit_p(i2c_pxa_remove),
> + .remove = __devexit_p(i2c_pxa_remove),
> .driver = {
> .name = "pxa2xx-i2c",
> .owner = THIS_MODULE,
Right, I think this should fix any hotplug problems that you have.
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-01-05 12:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 2:05 [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Dmitry Eremin-Solenikov
2011-01-05 2:05 ` Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 2/6] mfp-pxa27x: correct naming of GPIO13_KP_DKIN_7 Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 3/6] pxa2xx: update stored gpio settings in pxa2xx_mfp_set_lpm() Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 4/6] pcmcia: limit pxa2xx_balloon3 subdriver to balloon3 platform Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 5/6] pcmcia: limit pxa2xx_trizeps4 subdriver to trizeps4 platform Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 6/6] Fix eseries compilation if w100fb is not compiled in kernel Dmitry Eremin-Solenikov
2011-01-05 8:27 ` Uwe Kleine-König
2011-01-05 10:54 ` Uwe Kleine-König
2011-01-05 11:17 ` Dmitry Eremin-Solenikov
[not found] ` <1294193110-23958-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-05 8:24 ` [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Uwe Kleine-König
2011-01-05 8:24 ` Uwe Kleine-König
[not found] ` <20110105082445.GL25121-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-05 9:19 ` Ben Dooks
2011-01-05 9:19 ` Ben Dooks
[not found] ` <20110105091915.GV27131-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-01-06 11:01 ` [PATCH] i2c-pxa: fix unbidding/rebidding of the device Dmitry Eremin-Solenikov
2011-01-06 11:01 ` Dmitry Eremin-Solenikov
[not found] ` <1294311682-13287-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-06 12:40 ` Uwe Kleine-König
2011-01-06 12:40 ` Uwe Kleine-König
[not found] ` <20110106124028.GX25121-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-08 16:06 ` [PATCH] i2c-pxa: fix unbinding/rebinding " Dmitry Eremin-Solenikov
2011-01-08 16:06 ` Dmitry Eremin-Solenikov
[not found] ` <1294502804-6580-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-08 16:18 ` Uwe Kleine-König
2011-01-08 16:18 ` Uwe Kleine-König
[not found] ` <20110108161828.GC8237-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-15 13:59 ` Dmitry Eremin-Solenikov
2011-02-15 13:59 ` Dmitry Eremin-Solenikov
[not found] ` <AANLkTimO1KFNm5xZ+2qJoGQq-ndVg0ER3KKwf0RYYOLK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-15 16:23 ` Uwe Kleine-König
2011-02-15 16:23 ` Uwe Kleine-König
2011-01-05 12:17 ` Ben Dooks [this message]
2011-01-05 12:17 ` [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Ben Dooks
2011-01-08 17:42 ` Ben Dooks
2011-01-08 17:42 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105121731.GG817@trinity.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.