[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Jan 05, 2011 at 01:36:35PM +0100, Jes Sorensen wrote:
> On 01/05/11 13:34, Michael S. Tsirkin wrote:
> > On Wed, Jan 05, 2011 at 11:41:02AM +0100, Jes.Sorensen@redhat.com wrote:
> >> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >>
> >> strtosz() needs to return a 64 bit type even on 32 bit
> >> architectures. Otherwise qemu-img will fail to create disk
> >> images >= 2GB
> >>
> >> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > 
> > Nothing wrong with this patch, but should the function
> > be renamed to strtos64 then?
> 
> I don't think that adds any value to be honest. The problem with the old
> interface was that the return type differed depending on whether it was
> compiled on 32 vs 64 bit systems.
> 
> Cheers,
> Jes

Yes, but does not the name strtosz imply 'string to size'?
Further changing the name will help make sure there are no
users you forgot to update.

-- 
MST