From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/polldaemon.c
Date: 5 Jan 2011 12:59:47 -0000 [thread overview]
Message-ID: <20110105125947.30840.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-01-05 12:59:47
Modified files:
. : WHATS_NEW
tools : polldaemon.c
Log message:
Fail deamonization if lvmcache_init fail
FIXME Add proper cleanup
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1858&r2=1.1859
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/polldaemon.c.diff?cvsroot=lvm2&r1=1.39&r2=1.40
--- LVM2/WHATS_NEW 2011/01/05 12:33:51 1.1858
+++ LVM2/WHATS_NEW 2011/01/05 12:59:46 1.1859
@@ -1,5 +1,6 @@
Version 2.02.80 -
====================================
+ Fail poll daemon creation when lvmcache_init() fails.
Return defined value for errors in _copy_percent() and _snap_percent().
Correct return code of cmirrord when issuing 'start' when already running.
Fix wrongly paired unlocking of global lock in pvchange. (2.02.66)
--- LVM2/tools/polldaemon.c 2010/12/08 20:50:51 1.39
+++ LVM2/tools/polldaemon.c 2011/01/05 12:59:47 1.40
@@ -64,7 +64,9 @@
strncpy(*cmd->argv, "(lvm2)", strlen(*cmd->argv));
reset_locking();
- lvmcache_init();
+ if (!lvmcache_init())
+ /* FIXME Clean up properly here */
+ _exit(ECMD_FAILED);
dev_close_all();
return 1;
next reply other threads:[~2011-01-05 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 12:59 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 10:06 LVM2 ./WHATS_NEW tools/polldaemon.c zkabelac
2011-01-19 23:11 mbroz
2010-08-26 16:29 jbrassow
2010-08-23 11:34 mbroz
2009-09-30 17:43 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105125947.30840.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.