From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: omap: rx51: Add stereo output support to audio jack
Date: Wed, 5 Jan 2011 15:55:09 +0000 [thread overview]
Message-ID: <20110105155509.GC746@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1294242360-1903-1-git-send-email-jhnikula@gmail.com>
On Wed, Jan 05, 2011 at 05:46:00PM +0200, Jarkko Nikula wrote:
> This support could have been implemented earlier but I was targeting to have
> ASoC cross-device support first. But as there's no DAPM widgets anymore in
> TPA6130, I don't see any other way to implement this than by registering TPA6130
> controls to aic34a with tpa6130a2_add_controls and by using
> tpa6130a2_stereo_enable.
Having thought about it for at least a second I think we should have a
DAPM context in the cards for all the board-level stuff - does that seem
resonable? The patch itself looks good:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
in the context of the current APIs, though.
next prev parent reply other threads:[~2011-01-05 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 15:46 [PATCH] ASoC: omap: rx51: Add stereo output support to audio jack Jarkko Nikula
2011-01-05 15:55 ` Mark Brown [this message]
2011-01-05 16:29 ` Jarkko Nikula
2011-01-05 16:39 ` Mark Brown
2011-01-05 18:12 ` peter.ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105155509.GC746@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.