From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 07/11] ASoC: tegra: Add tegra-das driver Date: Wed, 5 Jan 2011 23:33:38 +0000 Message-ID: <20110105233338.GA5714@opensource.wolfsonmicro.com> References: <1292622090-21896-1-git-send-email-swarren@nvidia.com> <1292622090-21896-8-git-send-email-swarren@nvidia.com> <20101217220029.GD25609@sirena.org.uk> <74CDBE0F657A3D45AFBB94109FB122FF030FD78D90@HQMAIL01.nvidia.com> <20101222201118.GA8167@opensource.wolfsonmicro.com> <74CDBE0F657A3D45AFBB94109FB122FF0310567AAE@HQMAIL01.nvidia.com> <20110105231812.GC5476@opensource.wolfsonmicro.com> <74CDBE0F657A3D45AFBB94109FB122FF0310567AC4@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 29B862443D for ; Thu, 6 Jan 2011 00:33:22 +0100 (CET) Content-Disposition: inline In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0310567AC4@HQMAIL01.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Stephen Warren Cc: "linux-tegra@vger.kernel.org" , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org On Wed, Jan 05, 2011 at 03:27:17PM -0800, Stephen Warren wrote: > Mark Brown wrote: > > No, I don't think this should be made visible to machine drivers at all > > - they should just see a straight through mapping from the DMA channels > > to the ports in the first instance. > Oh. So what should set up this 1:1 mapping then; what module should the > DAS register writes be contained in? And later, what module should I guess the I2S driver? > configure the DAS with the mux configuration that is appropriate for > the board? It seems like the machine driver is the only place with the My suggestion would only work for very simple boards like Harmony. > knowledge to define what the routing should be. Whether the machine driver > calls tegra_das_* vs. some codec/mux API to set this up seems like a > different issue to whether the machine driver or something else should > contain this knowledge. The end result would be that this would all be done in the application layer, potentially dynamically. > In the short-term, are you expecting the I2S driver to expose a CPU DAI for > each audio controller and port? The number of audio controllers and ports > isn't equal, and hence it wouldn't be possible to support a board using just > port 5 since there's no controller 5 (and even audio controller 3 I think is > SPDIF not I2S)... Oh, hrm. That wasn't clear from your code. Would mapping controller n to port n work for Harmony?