All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Russ Gorby <russ.gorby@intel.com>
Cc: <gregkh@suse.de>, <segoon@openwall.com>,
	<richardx.r.gorby@intel.com>,
	linux-kernel@vger.kernel.org, suhail.ahmed@intel.com
Subject: Re: [PATCH 4/7] serial: ifx6x60: set SPI max_speed_hz based on platform type
Date: Thu, 6 Jan 2011 00:27:16 +0000	[thread overview]
Message-ID: <20110106002716.06a396c7@bob.linux.org.uk> (raw)
In-Reply-To: <1294272313-15899-5-git-send-email-russ.gorby@intel.com>

> +	if (ifx_dev->is_6160)
> +		spi->max_speed_hz = 12500000;
> +	else
> +		spi->max_speed_hz = 25000000;

This should be coming directly from the platform data, ditto I suspect
wiring the DMA to is_6160 should probably be a platform "use_dma"
field ?


  reply	other threads:[~2011-01-06  0:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH 0/7] IFX6X60 patchset: 01/05/2011>
2011-01-06  0:05 ` [PATCH 0/7] IFX6X60 patchset: 01/05/2011 Russ Gorby
2011-01-06  0:14   ` Greg KH
2011-01-06  0:33     ` Gorby, Russ
2011-01-06  3:19       ` Greg KH
2011-01-06  0:05 ` [PATCH 1/7] serial: ifx6x60: fixed call to tty_port_init Russ Gorby
2011-01-06  0:24   ` Alan Cox
2011-01-06  0:05 ` [PATCH 2/7] serial: ifx6x60: dma_alloc_coherent must use parent dev Russ Gorby
2011-01-06  0:05 ` [PATCH 3/7] serial: ifx6x60: changed internal bpw from boolean to int Russ Gorby
2011-01-06  0:25   ` Alan Cox
2011-01-06  0:05 ` [PATCH 4/7] serial: ifx6x60: set SPI max_speed_hz based on platform type Russ Gorby
2011-01-06  0:27   ` Alan Cox [this message]
2011-01-06 21:30     ` Gorby, Russ
2011-01-10 14:05       ` Alan Cox
2011-01-06  0:05 ` [PATCH 5/7] serial: ifx6x60: probe routine needs to call spi_setup Russ Gorby
2011-01-06  0:05 ` [PATCH 6/7] serial: ifx6x60: fix modem names to ones recognized by firmware Russ Gorby
2011-01-06  0:29   ` Alan Cox
2011-01-06  0:05 ` [PATCH 7/7] serial: ifx6x60: minor cleanup Russ Gorby
2011-01-06  0:29   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106002716.06a396c7@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardx.r.gorby@intel.com \
    --cc=russ.gorby@intel.com \
    --cc=segoon@openwall.com \
    --cc=suhail.ahmed@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.