From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] drm/i915: make DP training try a little harder Date: Thu, 6 Jan 2011 08:42:00 +0800 Message-ID: <20110106004200.GB2702@yliu-dev.sh.intel.com> References: <1294170794-5334-1-git-send-email-jbarnes@virtuousgeek.org> <20110105075239.GA2702@yliu-dev.sh.intel.com> <20110105091919.6da339d9@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D2B329EFA7 for ; Wed, 5 Jan 2011 16:43:30 -0800 (PST) Content-Disposition: inline In-Reply-To: <20110105091919.6da339d9@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 05, 2011 at 09:19:19AM -0800, Jesse Barnes wrote: [snip] > > > > And, FYI, the two patch would not fix bug > > https://bugs.freedesktop.org/show_bug.cgi?id=32539 > > the train link still failed. > > Does this one at least keep it from hanging? Oh, sorry, wrong bug number :( , it's 29791. > > If it doesn't actually help with suspend/resume, I wonder if we need to > use fast link training on that machine. The "use VBT provided values" > patch did that, using the VBT pre-emphasis and vswing values, but we > can also cache the last known good AUX handshake data and use that at > resume time too. Can you give that a try?