From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] drm/i915: skip FDI & PCH enabling for DP_A Date: Thu, 6 Jan 2011 09:42:26 +0800 Message-ID: <20110106014226.GC2702@yliu-dev.sh.intel.com> References: <1294252308-18736-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D444B9EFAC for ; Wed, 5 Jan 2011 17:43:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <1294252308-18736-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 05, 2011 at 10:31:48AM -0800, Jesse Barnes wrote: > eDP on the CPU doesn't need the PCH set up at all, it can in fact cause > problems. So avoid FDI training and PCH PLL enabling in that case. Hey, skip PCH set up on eDP does fix the bug 29791(eDP blank screen issue). Well, I didn't test with this patch, as it depends on the serial patches you send before(I would like to have a test today). I just made up a simple patch to skip PCH set up if HAS_eDP is met. Thanks, Yuanhan Liu