From: Paul Mundt <lethal@linux-sh.org>
To: Julia Lawall <julia@diku.dk>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/video/carminefb.c: improve error handling
Date: Thu, 06 Jan 2011 06:45:17 +0000 [thread overview]
Message-ID: <20110106064517.GD15340@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1101021527220.10933@ask.diku.dk>
On Sun, Jan 02, 2011 at 03:27:42PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> This code had an error handling goto to the wrong place, a misplaced
> release_mem_region, and a duplicated release_mem_region.
>
> The semantic match that finds the double release_mem_region is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e3;
> position p1,p2,p3;
> @@
> release_mem_region@p1(e1, e2)@p3;
> ... when != request_mem_region(e1,e2,e3)
> release_mem_region(e1, e2)@p2;
>
> @@
> expression e <= r.e1,e3;
> expression r.e1,e2;
> position r.p1,r.p2,r.p3,p!=r.p1;
> @@
> *release_mem_region(e1, e2)@p3;
> ... when != e = e3
> *release_mem_region@p(e1, e2)@p2;// </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Julia Lawall <julia@diku.dk>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/video/carminefb.c: improve error handling
Date: Thu, 6 Jan 2011 15:45:17 +0900 [thread overview]
Message-ID: <20110106064517.GD15340@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1101021527220.10933@ask.diku.dk>
On Sun, Jan 02, 2011 at 03:27:42PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> This code had an error handling goto to the wrong place, a misplaced
> release_mem_region, and a duplicated release_mem_region.
>
> The semantic match that finds the double release_mem_region is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e3;
> position p1,p2,p3;
> @@
> release_mem_region@p1(e1, e2)@p3;
> ... when != request_mem_region(e1,e2,e3)
> release_mem_region(e1, e2)@p2;
>
> @@
> expression e <= r.e1,e3;
> expression r.e1,e2;
> position r.p1,r.p2,r.p3,p!=r.p1;
> @@
> *release_mem_region(e1, e2)@p3;
> ... when != e = e3
> *release_mem_region@p(e1, e2)@p2;// </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
Applied, thanks.
next prev parent reply other threads:[~2011-01-06 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 14:27 [PATCH] drivers/video/carminefb.c: improve error handling Julia Lawall
2011-01-02 14:27 ` Julia Lawall
2011-01-06 6:45 ` Paul Mundt [this message]
2011-01-06 6:45 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106064517.GD15340@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.