From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51759 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PamAk-0005ak-I8
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 04:30:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PamAj-0008NS-CC
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 04:30:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PamAj-0008NL-3n
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 04:30:17 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p069UFH7007668
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 6 Jan 2011 04:30:15 -0500
Date: Thu, 6 Jan 2011 11:29:59 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110106092959.GA12142@redhat.com>
References: <1291123564-3249-1-git-send-email-kraxel@redhat.com>
	<1291123564-3249-3-git-send-email-kraxel@redhat.com>
	<20110105194406.GC28688@redhat.com> <4D258014.9080309@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D258014.9080309@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Jan 06, 2011 at 09:40:52AM +0100, Gerd Hoffmann wrote:
> >>diff --git a/hw/piix4.c b/hw/piix4.c
> >>index 5489386..1678898 100644
> >>--- a/hw/piix4.c
> >>+++ b/hw/piix4.c
> >>@@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = {
> >>          .qdev.desc    = "ISA bridge",
> >>          .qdev.size    = sizeof(PCIDevice),
> >>          .qdev.no_user = 1,
> >>+        .qdev.no_hotplug = 1,
> >>          .init         = piix4_initfn,
> >>      },{
> >>          /* end of list */
> >
> >This one breaks the build for me.  The below seems to help - but begs
> >the question: was this tested?
> 
> Tested on x86.  piix4 chipset is used by hw/mips_malta.c, looks like
> I forgot to do a testbuild with all targets enabled :-(

Let's just patch whatever was tested for now?

> >diff --git a/hw/piix4.c b/hw/piix4.c
> >index 1678898..00da049 100644
> >--- a/hw/piix4.c
> >+++ b/hw/piix4.c
> >@@ -113,7 +113,7 @@ static PCIDeviceInfo piix4_info[] = {
> >          .qdev.desc    = "ISA bridge",
> >          .qdev.size    = sizeof(PCIDevice),
> >          .qdev.no_user = 1,
> >-        .qdev.no_hotplug = 1,
> >+        .no_hotplug = 1,
> >          .init         = piix4_initfn,
> >      },{
> >          /* end of list */
> 
> This is correct.  Do you just squash in the fix or do you want me
> respin the patch series?
> 
> cheers,
>   Gerd

Could you split the tested and untested parts to separate patches,
noting the status in the commit message?
We could then queue the tested parts directly and wait for
maintainer's ack for the rest.

-- 
MST