Re: [PATCH 1/4] ASoC sst v2: Add sn95031 codec driver

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Jan 06, 2011 at 12:17:04PM +0530, Koul, Vinod wrote:

> > > +	/* PCM interface config
> > > +	 * This sets the pcm rx slot conguration to max 6 slots
> > > +	 * for max 4 dais (2 stereo and 2 mono)
> > > +	 */

> > This stuff should all be dynamically configured at runtime - the clocks
> > should be being managed with set_sysclk() and the slot configuration
> > with the TDM API or dynamic routing depending on what the actual control
> > is.

> Since we have single PCM port and TDM slots. For all DAIs it needs to be single
> configuration and not changed while one is running.

It's a big jump to go from not being able to configure while active to
hard coding within the CODEC driver - machine drivers should be able to
change this sort of thing during initialisation, and ideally also
dynamically where possible (for example, only while there are no active
audio streams).