Re: [PATCH 2/2 v2] xen: HVM X2APIC support

[Sheng Yang <sheng@linux.intel.com>]

On Thursday 06 January 2011 17:35:57 Ian Campbell wrote:
> On Thu, 2011-01-06 at 17:23 +0800, Sheng Yang wrote:
> > Thanks for the comments, but seems it's a little late. The patches have
> > been there for more than a month since the first version, and now they
> > are finally in the tree... And since it's not a bug, could we leave it
> > to the later clean up?
> 
> Sure. Are you going to do that?

OK, I would do it later.

--
regards
Yang, Sheng

> 
> > > > > Also, checking for the XenVMMXenVMM signature alone seems like a
> > > > > very broad test for checking the availability of a specific
> > > > > feature, is there nothing more specific which we could/should be
> > > > > testing?
> > > > 
> > > > The CPU flag x2apic is checked when we want to enable x2apic, and
> > > > only Xen which supported x2apic emulation would show this flag.
> > > 
> > > A comment to that effect, in the checkin commentary if not the code,
> > > would be a useful reminder of this.
> > 
> > The caller of the function indicate so, it's in the x2apic enabling
> > code(which is the same as KVM). So I think that maybe enough.
> 
> It's not obvious to the likes of me but if it makes sense to people who
> know x2apic (but not necessarily Xen or KVM) then I guess it's ok.
> 
> Ian.