Re: [PATCH] platform-driver-x86: ACPI EC Extra driver for Oaktrail

[Yin Kangkai <kangkai.yin@linux.intel.com>]

On 2011-01-06, 04:32 -0700, Joey Lee wrote:
> Hi Yin Kangkai, 
> 
> 於 四，2011-01-06 於 11:54 +0100，Corentin Chary 提到：
> > On Thu, Jan 6, 2011 at 11:50 AM, Yin Kangkai
> > <kangkai.yin@linux.intel.com> wrote:
> > > On 2011-01-06, 08:29 +0100, Corentin Chary wrote:
> > >> > + * gps - GPS subsystem enabled: contains either 0 or 1. (rw)
> > >> > + * wifi - WiFi subsystem enabled: contains either 0 or 1. (rw)
> > >> > + * wwan - WWAN (3G) subsystem enabled: contains either 0 or 1. (rw)
> > >>
> > >> Is there a reason do add these files in /sys/devices/platform while the
> > >> functionality is already provided by rfkill ?
> > >
> > > This is not the same functionality.
> > >
> > > enable/disable using files in /sys/devices/platform will completely
> > > cut power of those components. For example, if disabled, you can not
> > > list out those components using lsusb. Can we achieve this using
> > > rfkill?

My fault. they are actually the same. As you can see from function
oaktrail_rfkill_set(), when you use rfkill to block a component, it
write the bit in EC space, just exactly the same as writing files in
/sys/devices/platform.. 

> > oh, sorry then, I didn't understood that.
> > 
> > So, you're lucky, you can control both the device and the radio. I'm
> > not sure what's
> > the best thing to do here, you can probably keep these files here.
> > 
> > CCing Matthew, he may have something to say about that.

Sorry Corentin Chary, for the confusion.

> We should used rfkill to provide interface to userland for
> enable/disable wlan/bluetooth/wwan. You can set the killswitch state to
> soft block when your driver call EC function to disable devices.
> 
> Udev/HAL will forward the killswitch change event to userland, then
> userland application can do some response, e.g. show up OSD.
> And, userland app also can control killswitch by /dev/rfkill.
> 
> There also have a urfkill daemon to provide DBus to userland app for
> control killswitch:
>  http://freedesktop.org/wiki/Software/urfkill
> 
> Use rfkill interface is more standard then create special sysfs file
> in /sys/devices/platform/intel_oaktrail. 

Yeah, thanks Joey and Corentin for the comments, I will remove the
interface (wifi, 3g, bt, gps) from /sys/devices/platform.

Kangkai