From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Support for DS620
Date: Fri, 07 Jan 2011 11:34:23 +0000 [thread overview]
Message-ID: <20110107113423.GA14011@ericsson.com> (raw)
In-Reply-To: <4D0FB795.3010006@antcom.de>
On Fri, Jan 07, 2011 at 05:24:21AM -0500, Roland Stigge wrote:
> Hi,
>
> On 01/07/2011 02:39 AM, Guenter Roeck wrote:
> >> I'm attaching my updated patch. You can also merge from git.antcom.de,
> >> repo linux-2.6, branch ds620.
> >>
> >> I also added a runtime configuration device attribute for the thermostat
> >> functionality.
> >>
> > Unfortunately, that adds a non-standard and non-documented ABI attribute, so no one
> > will be able to use it. Also, from reading the specification, it seems like it would more
> > appropriate to set this through platform data (if it really has to be configurable).
>
> Oops, sorry!
>
> What can we do if we want to make it configurable at runtime? I'm not
> using it currently this way, but users could be. Or should we just make
> ist platform data to adhere to spec restrictions?
>
I would suggest to implement it as platform data. If anyone ever needs it runtime-configurable,
we can still think about some way to do it.
> > Btw, can you write Documentation/hwmon/ds620 ? I completely forgot to ask for that.
>
> It was already included in the last patches, since you already asked
> about it. :-)
>
I must be blind :(.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-01-07 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 20:07 [lm-sensors] [PATCH] Support for DS620 Roland Stigge
2010-12-23 19:55 ` Guenter Roeck
2010-12-25 13:24 ` Roland Stigge
2010-12-25 18:34 ` Guenter Roeck
2010-12-25 21:10 ` Roland Stigge
2010-12-25 22:13 ` Guenter Roeck
2010-12-25 23:05 ` Roland Stigge
2010-12-26 3:18 ` Guenter Roeck
2010-12-26 23:20 ` Roland Stigge
2011-01-02 23:31 ` Guenter Roeck
2011-01-06 18:03 ` Jean Delvare
2011-01-07 0:05 ` Roland Stigge
2011-01-07 1:39 ` Guenter Roeck
2011-01-07 10:24 ` Roland Stigge
2011-01-07 11:34 ` Guenter Roeck [this message]
2011-01-08 17:56 ` Roland Stigge
2011-01-08 18:54 ` Guenter Roeck
2011-01-09 0:01 ` Roland Stigge
2011-01-09 3:59 ` Guenter Roeck
2011-01-09 11:34 ` Roland Stigge
2011-01-09 14:31 ` Roland Stigge
2011-01-09 15:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107113423.GA14011@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.