Re: [PATCH 04/12] Nested Virtualization: core

[Christoph Egger <Christoph.Egger@amd.com>]

On Friday 07 January 2011 15:12:51 Tim Deegan wrote:
> At 15:58 +0000 on 03 Jan (1294070335), Christoph Egger wrote:
> > On Monday 27 December 2010 08:54:16 Dong, Eddie wrote:
> > > This is overcomplicated. Static table should serve this much simple and
> > > efficient.
> >
> > The logic to select the right static table will be still needed. I am
> > not sure if removing the _xmalloc() call simplifies this part a lot.
> >
> > I appreciate opinions from other people on this.
>
> I think that you should allocate the three static bitmaps once at boot
> time and not bother refcounting them.  It's only 36KiB of overhead for
> the entire host.
>
> Otherwise you'd have to decide what to do if _xmalloc() returned NULL.

I did not want to waste memory in the non-nested-virtualization case
but ok, I will go that way then.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632