From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
A Large Angry SCM <gitzilla@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t9010: svnadmin can fail even if available
Date: Fri, 7 Jan 2011 22:28:40 +0530 [thread overview]
Message-ID: <20110107165837.GA8062@kytes> (raw)
In-Reply-To: <20110107013159.GA23280@burratino>
Hi,
Jonathan Nieder writes:
> To do the same for t91* would be impossible. If svn is broken or not
> installed, svn-fe will run fine, but "git svn" will not. On the other
> hand, if svnadmin were broken but svn still worked, "git svn" would be
> fine but that would be quite strange and I do not think it is worth
> spending time to prepare for.
I don't think it's worth spending time preparing for every concievable
breakage. The patch A few more examples of possible breakages I've
encountered:
- APR compiled without threading support, SVN compiled with it, or
viceversa.
- SVN is compiled against GNU iconv, but apr-iconv installed, or
viceversa.
- Two different versions of a dependent library are installed, and SVN
links to a different version in a different location.
One or many components of SVN may fail. So, I'm in favor of the
current approach: if SVN is installed, attempt to run all the t91*
tests. Any failure can either be interpreted as a real test failure or
malformed SVN installation.
-- Ram
next prev parent reply other threads:[~2011-01-07 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 16:04 Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1) A Large Angry SCM
2011-01-06 16:59 ` Jonathan Nieder
2011-01-06 17:20 ` A Large Angry SCM
2011-01-06 18:00 ` [PATCH] t9010: svnadmin can fail even if available Jonathan Nieder
2011-01-06 18:32 ` A Large Angry SCM
2011-01-06 20:16 ` Junio C Hamano
2011-01-06 20:46 ` Jonathan Nieder
2011-01-07 1:07 ` Junio C Hamano
2011-01-07 1:31 ` Jonathan Nieder
2011-01-07 16:58 ` Ramkumar Ramachandra [this message]
2011-01-07 18:54 ` Junio C Hamano
2011-01-06 18:15 ` Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1) Junio C Hamano
2011-01-06 19:06 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107165837.GA8062@kytes \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.