From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] Add CMAKETARGETS infrastructure for CMake packages
Date: Fri, 7 Jan 2011 18:17:05 +0100 [thread overview]
Message-ID: <20110107181705.20654fb0@surf> (raw)
In-Reply-To: <1292182155-29576-2-git-send-email-bjorn.forsman@gmail.com>
Hello Bjorn,
On Sun, 12 Dec 2010 20:29:12 +0100
Bj?rn Forsman <bjorn.forsman@gmail.com> wrote:
> +# CMake doesn't support having the --sysroot option directly in the
> +# compiler path, so move this option to the CFLAGS/CXXFLAGS variables.
> +CMAKE_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC))
> +CMAKE_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX))
> +CMAKE_TARGET_CFLAGS = $(filter --sysroot=%,$(TARGET_CC)) $(TARGET_CFLAGS)
> +CMAKE_TARGET_CXXFLAGS = $(filter --sysroot=%,$(TARGET_CXX)) $(TARGET_CXXFLAGS)
Those definitions should be *outside* the CMAKETARGETS_INNER macro,
because:
1/ They might be useful even if no package makes use of the
CMAKETARGETS infrastructure
2/ They are not package specific, so they have no reason to be inside
the macro.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-01-07 17:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 19:29 [Buildroot] [PATCH 0/4] Introducing CMAKETARGETS infrastructure Bjørn Forsman
2010-12-12 19:29 ` [Buildroot] [PATCH 1/4] Add CMAKETARGETS infrastructure for CMake packages Bjørn Forsman
2010-12-13 22:27 ` Samuel Martin
2010-12-14 11:13 ` Bjørn Forsman
2010-12-22 21:34 ` Samuel Martin
2010-12-23 7:46 ` Thomas Petazzoni
2010-12-23 8:46 ` Bjørn Forsman
2010-12-23 8:54 ` Thomas Petazzoni
2010-12-23 9:14 ` Bjørn Forsman
2011-01-07 17:17 ` Thomas Petazzoni [this message]
2011-01-08 23:44 ` Bjørn Forsman
2011-01-10 17:51 ` Thomas Petazzoni
2011-01-10 20:14 ` Bjørn Forsman
2010-12-12 19:29 ` [Buildroot] [PATCH 2/4] doc: add CMAKETARGETS documentation Bjørn Forsman
2010-12-12 19:29 ` [Buildroot] [PATCH 3/4] Makefile: generate CMake toolchain file in $(O) Bjørn Forsman
2010-12-13 22:27 ` Samuel Martin
2010-12-14 12:39 ` Bjørn Forsman
2010-12-22 21:32 ` Samuel Martin
2010-12-23 7:48 ` Thomas Petazzoni
2010-12-24 12:25 ` Samuel Martin
2010-12-23 9:04 ` Bjørn Forsman
2010-12-24 12:26 ` Samuel Martin
2011-01-07 17:15 ` Thomas Petazzoni
2011-01-08 23:42 ` Bjørn Forsman
2011-01-09 12:52 ` Bjørn Forsman
2011-01-09 14:08 ` Thomas Petazzoni
2011-01-10 17:50 ` Thomas Petazzoni
2011-01-10 18:30 ` Bjørn Forsman
2011-01-10 22:28 ` Thomas Petazzoni
2011-01-11 10:22 ` Thomas Petazzoni
2011-01-11 10:27 ` Thomas Petazzoni
2011-01-15 13:50 ` Bjørn Forsman
2010-12-12 19:29 ` [Buildroot] [PATCH 4/4] cdrkit: convert to CMAKETARGETS infrastructure Bjørn Forsman
2010-12-13 22:28 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107181705.20654fb0@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.