From: Chris Ball <cjb@laptop.org>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: Philip Rakity <prakity@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Mark Brown <markb@marvell.com>
Subject: Re: [PATCH V2 2/2] sdhci: Support for SD/MMC Dual Data Rate
Date: Sun, 9 Jan 2011 23:28:12 +0000 [thread overview]
Message-ID: <20110109232812.GA26728@void.printf.net> (raw)
In-Reply-To: <AANLkTi=ERwn3W8tvt3NNS3Xiq93mhy7TV7vAT9dwjvaq@mail.gmail.com>
Hi Philip, Zhangfei,
We've got two patches from Marvell for SD/DDR now. Any agreement on
which of them to merge?
On Mon, Jan 03, 2011 at 10:39:46PM -0500, zhangfei gao wrote:
> > + /* Change sigalling voltage and wait for it to be stable */
> > + if (host->ops->set_signaling_voltage)
> > + host->ops->set_signaling_voltage(host, 18);
> > + else
> > + mdelay(5);
>
> In fact, have considered this method before, mdelay(5) in
> spin_lock_irqsave is terrible, since timer can not update system time,
> and android must die.
Philip, is there a reason not to use msleep() here instead?
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-09 23:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 16:45 [PATCH V2 2/2] sdhci: Support for SD/MMC Dual Data Rate Philip Rakity
2011-01-02 18:55 ` Chris Ball
2011-01-02 19:02 ` Philip Rakity
2011-01-02 19:32 ` Chris Ball
2011-01-02 19:53 ` [PATCH V3 " Philip Rakity
2011-01-04 3:39 ` [PATCH V2 " zhangfei gao
2011-01-04 4:25 ` Philip Rakity
2011-01-04 4:37 ` Philip Rakity
2011-01-04 4:52 ` Philip Rakity
2011-01-04 4:41 ` Philip Rakity
2011-01-09 23:28 ` Chris Ball [this message]
2011-01-10 3:05 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109232812.GA26728@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=markb@marvell.com \
--cc=prakity@marvell.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.