From: Amos Kong <akong@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [Autotest] [PATCH] KVM test: Fix typos in ethtool
Date: Mon, 10 Jan 2011 15:17:14 +0800 [thread overview]
Message-ID: <20110110071714.GA3978@t400> (raw)
In-Reply-To: <1294413669-5497-1-git-send-email-lmr@redhat.com>
On Fri, Jan 07, 2011 at 01:21:09PM -0200, Lucas Meneghel Rodrigues wrote:
> Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> ---
> client/tests/kvm/tests/ethtool.py | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/client/tests/kvm/tests/ethtool.py b/client/tests/kvm/tests/ethtool.py
> index 011df29..9708497 100644
> --- a/client/tests/kvm/tests/ethtool.py
> +++ b/client/tests/kvm/tests/ethtool.py
> @@ -104,11 +104,11 @@ def run_ethtool(test, params, env):
> if src == "guest":
> session.cmd_output(dd_cmd, timeout=360)
> tcpdump_cmd += " and src %s" % guest_ip
> - copy_files_fun = vm.copy_files_from
> + copy_files_from = vm.copy_files_from
> else:
> s, o = commands.getstatusoutput(dd_cmd)
> tcpdump_cmd += " and dst %s" % guest_ip
> - copy_files_fun = vm.copy_files_to
> + copy_files_from = vm.copy_files_to
> if s != 0:
> return (False, "Fail to create file by dd, cmd: %s" % dd_cmd)
>
> @@ -125,7 +125,7 @@ def run_ethtool(test, params, env):
>
> logging.info("Start to transfer file")
> try:
> - copy_files_fun(filename, filename):
> + copy_files_from(filename, filename)
Does this patch base on a wrong fix ?
there is no 'copy_files_fun(filename, filename):' in original ethtool.py
Current ethtool.py also exists an typo, will send a patch to fix this.
> except kvm_utils.SCPError, e:
> return (False, "File transfer failed (%s)" % e)
> logging.info("Transfer file completed")
> --
> 1.7.3.4
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
prev parent reply other threads:[~2011-01-10 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 15:21 [PATCH] KVM test: Fix typos in ethtool Lucas Meneghel Rodrigues
2011-01-10 7:17 ` Amos Kong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110071714.GA3978@t400 \
--to=akong@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.