From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH][VTD] bug fix for EPT/VT-d table	 sharing
Date: Mon, 10 Jan 2011 10:52:54 +0100
Message-ID: <20110110095254.GA2472@aepfle.de>
References: <987664A83D2D224EAE907B061CE93D530193FC6195@orsmsx505.amr.corp.intel.com>
	<4D258EB2020000780002AA9F@vpn.id2.novell.com>
	<987664A83D2D224EAE907B061CE93D53019400FE55@orsmsx505.amr.corp.intel.com>
	<4D26DBF1020000780002AEF5@vpn.id2.novell.com>
	<987664A83D2D224EAE907B061CE93D53019401026E@orsmsx505.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <987664A83D2D224EAE907B061CE93D53019401026E@orsmsx505.amr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Kay, Allen M" <allen.m.kay@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Keir Fraser <keir@xen.org>, Tim Deegan <Tim.Deegan@citrix.com>, Jan Beulich <JBeulich@novell.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jan 07, Kay, Allen M wrote:

> >@@ -548,17 +533,12 @@ static int inline iommu_flush_iotlb_psi(
> >     if ( !cap_pgsel_inv(iommu->cap) )
> >         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry, flush_dev_iotlb);
> > 
> >-    /*
> >-     * PSI requires page size is 2 ^ x, and the base address is naturally
> >-     * aligned to the size
> >-     */
> >-    align = get_alignment(addr >> PAGE_SHIFT_4K, pages);
> >     /* Fallback to domain selective flush if size is too big */
> >-    if ( align > cap_max_amask_val(iommu->cap) )
> >+    if ( order > cap_max_amask_val(iommu->cap) )

This leaves 'align' uninitialized when flush->iotlb() is called.

iommu.c:546: error: 'align' may be used uninitialized in this function


Olaf