From: Joerg Roedel <joro@8bytes.org>
To: Zachary Amsden <zamsden@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Glauber Costa <glommer@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [KVM TSC trapping / migration 1/2] Add TSC trapping for SVM and VMX
Date: Mon, 10 Jan 2011 12:52:36 +0100 [thread overview]
Message-ID: <20110110115236.GF6376@8bytes.org> (raw)
In-Reply-To: <1294308645-31113-2-git-send-email-zamsden@redhat.com>
On Thu, Jan 06, 2011 at 12:10:44AM -1000, Zachary Amsden wrote:
> +static void svm_set_tsc_trapping(struct kvm_vcpu *vcpu, bool trap)
> +{
> + struct vcpu_svm *svm = to_svm(vcpu);
> + if (trap)
> + svm->vmcb->control.intercept |= 1ULL << INTERCEPT_RDTSC;
> + else
> + svm->vmcb->control.intercept &= ~(1ULL << INTERCEPT_RDTSC);
> +}
This needs to update the clean-bits. Please use
set_intercept/clr_intercept instead which already takes care of this.
Joerg
next prev parent reply other threads:[~2011-01-10 11:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 10:10 KVM TSC trapping Zachary Amsden
2011-01-06 10:10 ` [KVM TSC trapping / migration 1/2] Add TSC trapping for SVM and VMX Zachary Amsden
2011-01-06 10:41 ` Alexander Graf
2011-01-06 11:30 ` Zachary Amsden
2011-01-06 11:38 ` Alexander Graf
2011-01-06 20:24 ` Zachary Amsden
2011-01-06 22:38 ` Alexander Graf
2011-01-07 3:10 ` Zachary Amsden
2011-01-06 11:32 ` Avi Kivity
2011-01-06 20:03 ` Zachary Amsden
2011-01-07 11:23 ` Marcelo Tosatti
2011-01-09 8:05 ` Zachary Amsden
2011-01-10 11:52 ` Joerg Roedel [this message]
2011-01-06 10:10 ` Zachary Amsden
2011-01-06 10:10 ` [KVM TSC trapping / migration 2/2] Add TSC KHZ MSR Zachary Amsden
2011-01-06 10:34 ` Alexander Graf
2011-01-06 11:27 ` Zachary Amsden
2011-01-06 11:40 ` Alexander Graf
2011-01-06 20:34 ` Zachary Amsden
2011-01-07 10:48 ` Marcelo Tosatti
2011-01-07 20:44 ` Zachary Amsden
2011-01-10 13:50 ` Marcelo Tosatti
2011-01-14 11:00 ` Juan Quintela
2011-01-18 15:47 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110115236.GF6376@8bytes.org \
--to=joro@8bytes.org \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.