Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card

From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Subject: Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card
Date: Mon, 10 Jan 2011 14:40:06 +0100	[thread overview]
Message-ID: <20110110134006.GC31011@pengutronix.de> (raw)
In-Reply-To: <20110110133112.GA324-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]

> > > +	if (type != 0xffff) {
> > > +		dev_alert(&card->pdev->dev, "firware starts with type 0x%04x\n",
> > 
> > Typo?
> > 
> ??

I think he means "fir[m]ware"

> > > +
> > > +int softing_default_output(struct net_device *netdev)
> > > +{
> > > +	struct softing_priv *priv = netdev_priv(netdev);
> > > +	struct softing *card = priv->card;
> > > +
> > > +	switch (priv->chip) {
> > > +	case 1000:
> > > +		if (card->pdat->generation < 2)
> > > +			return 0xfb;
> > > +		return 0xfa;

A ternary operator might look nicer here because of just a single return.

Best wishes,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 188 bytes --]

_______________________________________________
Socketcan-core mailing list
Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
https://lists.berlios.de/mailman/listinfo/socketcan-core