From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] [v2] ASoC: cs4270: use the built-in register cache support Date: Mon, 10 Jan 2011 18:23:02 +0000 Message-ID: <20110110182302.GB26137@opensource.wolfsonmicro.com> References: <1294675292-6289-1-git-send-email-timur@freescale.com> <1294676990.11031.10.camel@dplaptop.localdomain> <4D2B34C1.7050209@freescale.com> <1294677365.11031.13.camel@dplaptop.localdomain> <4D2B4376.101@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 8229A2454B for ; Mon, 10 Jan 2011 19:25:04 +0100 (CET) Content-Disposition: inline In-Reply-To: <4D2B4376.101@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Mon, Jan 10, 2011 at 11:35:50AM -0600, Timur Tabi wrote: > This doesn't seem right to me. Here, the .put function returns 0 or 1, > depending on whether or not the bits were actually updated. Is that what's > intended? I can't find any documentation that tells me what the return values > of snd_kcontrol_put_t are supposed to be. It's supposed to be 1 for change, 0 for no change or an error - if you look at the core functions you'll see that they generally all follow this idiom of using the return value from snd_soc_update_bits() directly.