From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] libxc: build fixes
Date: Tue, 11 Jan 2011 11:41:32 +0100
Message-ID: <20110111104132.GA2982@aepfle.de>
References: <201101061646.53565.Christoph.Egger@amd.com>
	<19749.64362.58747.605990@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <19749.64362.58747.605990@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 06, Ian Jackson wrote:

> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"):
> > Attached patch makes libxc build again on NetBSD after the recent rework.
> 
> I have applied this.  However:
> 
> I changed the name of the new make variable from LIBDL to DLOPEN_LIBS.
> The latter conforms to the naming scheme for similar variables found
> in config/*.mk - PTHREAD_LIBS et al.
> 
> Also I moved the setting of the variable to -dl from Linux to StdGNU
> (which makes it apply more widely) and also added it to SunOS.mk
> (based on pure guesswork).

This is incomplete. flask does not build because linking fails with
missing dlopen/dlsym etc. This change fixes it for me.


Signed-off-by: Olaf Hering <olaf@aepfle.de>
 
--- xen-unstable.hg-4.1.22697.orig/tools/Rules.mk
+++ xen-unstable.hg-4.1.22697/tools/Rules.mk
@@ -18,7 +18,7 @@ XEN_BLKTAP2        = $(XEN_ROOT)/tools/b
 CFLAGS_include = -I$(XEN_INCLUDE)
 
 CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_include)
-LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl
+LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl $(DLOPEN_LIBS)
 
 CFLAGS_libxenguest = -I$(XEN_LIBXC) $(CFLAGS_include)
 LDLIBS_libxenguest = -L$(XEN_LIBXC) -lxenguest