From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Ahern <daahern@cisco.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
tzanussi@gmail.com, Paul Mackerras <paulus@samba.org>,
imunsie@au1.ibm.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org
Subject: Re: perf: commit 55b4462 causes perf record to hang
Date: Tue, 11 Jan 2011 09:35:02 -0200 [thread overview]
Message-ID: <20110111113502.GC20234@ghostprotocols.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1101110927290.12146@localhost6.localdomain6>
Em Tue, Jan 11, 2011 at 09:28:25AM +0100, Thomas Gleixner escreveu:
> On Mon, 10 Jan 2011, Arnaldo Carvalho de Melo wrote:
> > Can you try with this patch, not reverting tglx's patch?
> >
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 6fb4694..313dac2 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1007,7 +1007,7 @@ more:
> > if (size == 0)
> > size = 8;
> >
> > - if (head + event->header.size >= mmap_size) {
> > + if (head + event->header.size > mmap_size) {
> > if (mmaps[map_idx]) {
> > munmap(mmaps[map_idx], mmap_size);
> > mmaps[map_idx] = NULL;
> >
>
> /me feels stupid
I feel like that sometimes too, probably more often than you :-P
- Arnaldo
prev parent reply other threads:[~2011-01-11 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 18:47 perf: commit 55b4462 causes perf record to hang David Ahern
2011-01-10 18:47 ` David Ahern
2011-01-10 19:40 ` Arnaldo Carvalho de Melo
2011-01-10 20:00 ` Arnaldo Carvalho de Melo
2011-01-10 20:07 ` David Ahern
2011-01-11 8:28 ` Thomas Gleixner
2011-01-11 11:35 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111113502.GC20234@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=daahern@cisco.com \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.