From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: Fix section mismatch in wm8995.c
Date: Tue, 11 Jan 2011 17:28:40 +0000 [thread overview]
Message-ID: <20110111172839.GE13429@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hlj2r9x52.wl%tiwai@suse.de>
On Tue, Jan 11, 2011 at 06:18:49PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > Hrm, it'd be better to find some annotation for the pointer which lets
> > us have the reference. We at a higher level only dereference the
> > pointer from the probe path, preventing the discard isn't a great
> > solution.
> Nah, that's way too complex for the time being. I really prefer a
> warning-less code for such a case.
The array is ~25k so it's not a completely trivial amount of memory,
unfortunately.
> The whole __init stuff have lots of potential improvements. But,
> improving it would cost pretty much. And we don't want yet another
> new annotation...
Very true. The other option is to refactor all the data structures to
appease it which is painful.
next prev parent reply other threads:[~2011-01-11 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 17:02 Fix section mismatch in wm8995.c Takashi Iwai
2011-01-11 17:10 ` Mark Brown
2011-01-11 17:18 ` Takashi Iwai
2011-01-11 17:28 ` Mark Brown [this message]
2011-01-11 17:32 ` Takashi Iwai
2011-01-11 17:33 ` Mark Brown
2011-01-11 17:48 ` Takashi Iwai
2011-01-11 18:14 ` Mark Brown
2011-01-11 19:12 ` Takashi Iwai
2011-01-12 9:58 ` Dimitris Papastamos
2011-01-12 10:46 ` Mark Brown
2011-01-12 10:50 ` Dimitris Papastamos
2011-01-12 10:00 ` Dimitris Papastamos
2011-01-12 10:03 ` Takashi Iwai
2011-01-12 10:07 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111172839.GE13429@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.