From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM i.MXS: Add auart platform support for i.MX28
Date: Wed, 12 Jan 2011 13:06:44 +0800 [thread overview]
Message-ID: <20110112050644.GC2888@freescale.com> (raw)
In-Reply-To: <20110111151725.GT24920@pengutronix.de>
On Tue, Jan 11, 2011 at 04:17:25PM +0100, Uwe Kleine-K?nig wrote:
> Hello Sascha,
>
> On Tue, Jan 11, 2011 at 04:09:05PM +0100, Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/mach-mxs/clock-mx28.c | 5 ++
> > arch/arm/mach-mxs/devices-mx28.h | 8 +++
> > arch/arm/mach-mxs/devices/Kconfig | 3 +
> > arch/arm/mach-mxs/devices/Makefile | 1 +
> > arch/arm/mach-mxs/devices/platform-auart.c | 54 +++++++++++++++++++++++
> > arch/arm/mach-mxs/include/mach/devices-common.h | 10 ++++
> > 6 files changed, 81 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-mxs/devices/platform-auart.c
> >
> > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
> > index 74e2103..9f65934 100644
> > --- a/arch/arm/mach-mxs/clock-mx28.c
> > +++ b/arch/arm/mach-mxs/clock-mx28.c
> > @@ -603,6 +603,11 @@ _DEFINE_CLOCK(fec_clk, ENET, DISABLE, &hbus_clk);
> >
> > static struct clk_lookup lookups[] = {
> > _REGISTER_CLOCK("mxs-duart.0", NULL, uart_clk)
> > + _REGISTER_CLOCK("mxs-auart.0", NULL, uart_clk)
> > + _REGISTER_CLOCK("mxs-auart.1", NULL, uart_clk)
> > + _REGISTER_CLOCK("mxs-auart.2", NULL, uart_clk)
> > + _REGISTER_CLOCK("mxs-auart.3", NULL, uart_clk)
> > + _REGISTER_CLOCK("mxs-auart.4", NULL, uart_clk)
> > _REGISTER_CLOCK("fec.0", NULL, fec_clk)
> > _REGISTER_CLOCK("rtc", NULL, rtc_clk)
> > _REGISTER_CLOCK("pll2", NULL, pll2_clk)
> > diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h
> > index 00b736c..a0b70df 100644
> > --- a/arch/arm/mach-mxs/devices-mx28.h
> > +++ b/arch/arm/mach-mxs/devices-mx28.h
> > @@ -15,6 +15,14 @@ extern const struct mxs_duart_data mx28_duart_data __initconst;
> > #define mx28_add_duart() \
> > mxs_add_duart(&mx28_duart_data)
> >
> > +extern const struct mxs_auart_data mx28_auart_data[] __initconst;
> > +#define mx28_add_auart(id) mxs_add_auart(&mx28_auart_data[id])
> > +#define mx28_add_auart0() mx28_add_auart(0)
> > +#define mx28_add_auart1() mx28_add_auart(1)
> > +#define mx28_add_auart2() mx28_add_auart(2)
> > +#define mx28_add_auart3() mx28_add_auart(3)
> > +#define mx28_add_auart4() mx28_add_auart(4)
> I wouldn't add the mx28_add_auartX macros, only mx28_add_auart. The
> former are a relict of the time when we didn't use an array to get the
> data from.
>
> > +
> > extern const struct mxs_fec_data mx28_fec_data[] __initconst;
> > #define mx28_add_fec(id, pdata) \
> > mxs_add_fec(&mx28_fec_data[id], pdata)
> > diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig
> > index a35a2dc..9d16540 100644
> > --- a/arch/arm/mach-mxs/devices/Kconfig
> > +++ b/arch/arm/mach-mxs/devices/Kconfig
> > @@ -1,5 +1,8 @@
> > config MXS_HAVE_PLATFORM_DUART
> > bool
> >
> > +config MXS_HAVE_PLATFORM_AUART
> > + bool
> > +
> This doesn't happen to be an amba device, too?
>
> > config MXS_HAVE_PLATFORM_FEC
> > bool
> > diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile
> > index 4b5266a..b46d18d 100644
> > --- a/arch/arm/mach-mxs/devices/Makefile
> > +++ b/arch/arm/mach-mxs/devices/Makefile
> > @@ -1,2 +1,3 @@
> > obj-$(CONFIG_MXS_HAVE_PLATFORM_DUART) += platform-duart.o
> > +obj-$(CONFIG_MXS_HAVE_PLATFORM_AUART) += platform-auart.o
> > obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o
> this conflicts with the "make duart use amba-pl011 driver" patch.
May I know the reason that the patch is still pending for being
merged? DEBUG_SPINLOCK_SLEEP warning?
[...]
--
Regards,
Shawn
next prev parent reply other threads:[~2011-01-12 5:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 15:09 Add i.MX23/28 auart support Sascha Hauer
2011-01-11 15:09 ` [PATCH 1/2] serial: Add auart driver for i.MX23/28 Sascha Hauer
2011-01-11 16:05 ` Russell King - ARM Linux
2011-01-11 17:10 ` Wolfram Sang
2011-01-11 17:57 ` Sascha Hauer
2011-01-12 5:39 ` Shawn Guo
2011-01-11 15:09 ` [PATCH 2/2] ARM i.MXS: Add auart platform support for i.MX28 Sascha Hauer
2011-01-11 15:17 ` Uwe Kleine-König
2011-01-11 15:26 ` Sascha Hauer
2011-01-12 5:06 ` Shawn Guo [this message]
2011-01-12 6:17 ` Shawn Guo
2011-01-12 5:31 ` Add i.MX23/28 auart support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112050644.GC2888@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.