From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: xen boot crash
Date: Wed, 12 Jan 2011 11:01:41 +0100
Message-ID: <20110112100141.GA14960@aepfle.de>
References: <201101121045.06045.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <201101121045.06045.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Wed, Jan 12, Christoph Egger wrote:

> 
> Hi!
> 
> Changeset 22706:ca10302ac285  causes below boot crash.
> Reverting it makes xen boot again.
> 
> The rip points to xen/common/page_alloc.c:543

Yes, that change was not well done. Sorry for that. I'm sure it doesnt
crash if set_gpfn_from_mfn() is called from free_domheap_pages().

Looking at free_heap_pages(), now the page owner is cleared at the
beginning of the loop. But later in the loop it is checked wether a TLB
flush is required. So the set_gpfn_from_mfn() should be at least moved
past this check. Even if that doesnt fix the crash you are seening.

I will see if I can come up with a better version.


Olaf