From: Olaf Hering <olaf@aepfle.de>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: xen boot crash
Date: Wed, 12 Jan 2011 14:37:50 +0100 [thread overview]
Message-ID: <20110112133750.GA7286@aepfle.de> (raw)
In-Reply-To: <20110112100141.GA14960@aepfle.de>
On Wed, Jan 12, Olaf Hering wrote:
> On Wed, Jan 12, Christoph Egger wrote:
>
> >
> > Hi!
> >
> > Changeset 22706:ca10302ac285 causes below boot crash.
> > Reverting it makes xen boot again.
> >
> > The rip points to xen/common/page_alloc.c:543
>
> Yes, that change was not well done. Sorry for that. I'm sure it doesnt
> crash if set_gpfn_from_mfn() is called from free_domheap_pages().
>
> Looking at free_heap_pages(), now the page owner is cleared at the
> beginning of the loop. But later in the loop it is checked wether a TLB
> flush is required. So the set_gpfn_from_mfn() should be at least moved
> past this check. Even if that doesnt fix the crash you are seening.
>
> I will see if I can come up with a better version.
It crashes in end_boot_allocator -> init_heap_pages -> free_heap_pages.
paging_init() initializes the machine_to_phys_mapping[] array, but its
called after end_boot_allocator().
As Keir said, there needs to be a more complete change for the
machine_to_phys_mapping[] array handling.
Olaf
next prev parent reply other threads:[~2011-01-12 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 9:45 xen boot crash Christoph Egger
2011-01-12 10:01 ` Olaf Hering
2011-01-12 13:37 ` Olaf Hering [this message]
2011-01-12 10:09 ` Jan Beulich
2011-01-12 10:52 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112133750.GA7286@aepfle.de \
--to=olaf@aepfle.de \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.