From: Greg KH <greg@kroah.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Roland Stigge <stigge@antcom.de>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
"Hennerich, Michael" <Michael.Hennerich@analog.com>
Subject: Re: Linux driver for MAX517/518/519
Date: Wed, 12 Jan 2011 07:34:13 -0800 [thread overview]
Message-ID: <20110112153413.GA21087@kroah.com> (raw)
In-Reply-To: <4D2D8E86.2000204@cam.ac.uk>
On Wed, Jan 12, 2011 at 11:20:38AM +0000, Jonathan Cameron wrote:
> On 01/12/11 09:44, Roland Stigge wrote:
> > Hi,
> >
> > On 01/11/2011 08:34 PM, Jonathan Cameron wrote:
> >>> On 01/09/2011 11:31 PM, Jonathan Cameron wrote:
> >>>> Pretty clean and nice driver so it was an easy review and should
> >>>> be trivial to fix up for a merge.
> >>>
> >>> Thanks for your review!
> >>>
> >>> I'm attaching my update. Some notes:
> >>>
> >>> * I used the attributes out1_* how I found it in the other DAC driver
> >>> already available
> >> Cool, except for the out12_raw which could easily be the 12th channel.
> >> This has to be one of the two options suggested the other day.
> >> May require some macro magic. IIRC the relevant macro would be.
> >>
> >> IIO_DEVICE_ATTR_NAMED(out1and2_raw, out1&2_raw, S_IWUSR, ...
> >
> > Update attached as suggested. :-)
> >
> > Thanks!
> >
> > Roland
>
> Probably worth sending it to Greg KH in a new thread so that he
> picks up on the fact that it is ready to merge. Given the volume
> of email he probably gets I doubt he is still reading this thread!
> No need to cc that to the list given we have this email.
Heh, I'm still here reading this :)
Roland sent me an updated version, I'll queue that up after .38-rc1 is
out.
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-12 15:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D21A2AA.6080006@antcom.de>
[not found] ` <20110103222834.GA11277@kroah.com>
2011-01-09 14:29 ` Linux driver for MAX517/518/519 Roland Stigge
2011-01-09 22:31 ` Jonathan Cameron
2011-01-10 9:27 ` Roland Stigge
2011-01-10 11:02 ` Jonathan Cameron
2011-01-11 16:20 ` Roland Stigge
2011-01-11 19:34 ` Jonathan Cameron
2011-01-12 9:44 ` Roland Stigge
2011-01-12 11:20 ` Jonathan Cameron
2011-01-12 15:34 ` Greg KH [this message]
2011-01-12 15:44 ` Jonathan Cameron
2011-01-12 15:43 ` Greg KH
2011-01-09 18:09 ` Roland Stigge
2011-01-09 20:55 ` J.I. Cameron
2011-01-09 21:05 ` J.I. Cameron
2011-01-09 21:33 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112153413.GA21087@kroah.com \
--to=greg@kroah.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.