Re: [PATCH 02/13] imsm: FIX: allow for container reshape any unset size value

[NeilBrown <neilb@suse.de>]

On Wed, 12 Jan 2011 08:32:10 +0000 "Kwolek, Adam" <adam.kwolek@intel.com>
wrote:


> This issue can be addressed in the following way:
> 
> >From ce0a720c162c425ae46684ac7866f7076e65d5e5 Mon Sep 17 00:00:00 2001
> From: Adam Kwolek <adam.kwolek@intel.com>
> Date: Wed, 12 Jan 2011 09:23:53 +0100
> Subject: [PATCH] FIX: size is passed incorrectly
> 
> reshape_super() called from reshape_container() with size set to info->component_size
> gives size in reshape_super == -2 due to unsigned signed conversion
> (info->component_size is not initializes).
> 
> As size is not changed during container reshape '-1' value is passed to indicate this.

Excellent problem description that allows me to immediately see the that the
solution is obviously correct.
Thanks.  Applied and pushed out.

NeilBrown


> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>  Grow.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Grow.c b/Grow.c
> index 4cbe427..466d546 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2120,7 +2120,7 @@ int reshape_container(char *container, int cfd, char *devname,
>  {
>  	struct mdinfo *cc = NULL;
>  
> -	if (reshape_super(st, info->component_size, info->new_level,
> +	if (reshape_super(st, -1, info->new_level,
>  			  info->new_layout, info->new_chunk,
>  			  info->array.raid_disks + info->delta_disks,
>  			  backup_file, devname, quiet))