From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58056 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdKwN-0007Ui-Gr
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:02:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PdKwM-0005Ax-8N
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:02:03 -0500
Received: from mail-bw0-f45.google.com ([209.85.214.45]:40389)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PdKwM-0005Ak-3b
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:02:02 -0500
Received: by bwz16 with SMTP id 16so1369477bwz.4
	for <qemu-devel@nongnu.org>; Thu, 13 Jan 2011 03:02:01 -0800 (PST)
Date: Thu, 13 Jan 2011 12:01:56 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit
Message-ID: <20110113110156.GC7296@edde.se.axis.com>
References: <a8ac13b48a00dbb6e633204fbee460f2396f95a1.1294136554.git.chouteau@adacore.com>
	<4D2EC4E2.4080000@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2EC4E2.4080000@adacore.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-devel@nongnu.org

On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote:
> On 01/04/2011 11:27 AM, Fabien Chouteau wrote:
> > On Windows, this is required to flush the remaining data in the IO stream,
> > otherwise Gdb do not receive the last packet.
> >
> > Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
> > ---
> >   gdbstub.c |    4 ++++
> >   1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/gdbstub.c b/gdbstub.c
> > index 0aa081b..dac3ce6 100644
> > --- a/gdbstub.c
> > +++ b/gdbstub.c
> > @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code)
> >
> >     snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
> >     put_packet(s, buf);
> > +
> > +  if (s->chr) {
> > +      qemu_chr_close(s->chr);
> > +  }
> >   }
> >
> >   #ifdef CONFIG_USER_ONLY
> 
> Any comment on this patch?

Yes, sorry for the delays. This patch breaks the linux-user build.

Cheers