From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: Harsha Priya <harsha.priya@intel.com>,
alsa-devel@alsa-project.org, selma.bensaid@intel.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 4/4] ASoC: soc core allow machine driver to register the card
Date: Thu, 13 Jan 2011 23:41:35 +0000 [thread overview]
Message-ID: <20110113234135.GD13717@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1294939150-26443-1-git-send-email-vinod.koul@intel.com>
On Thu, Jan 13, 2011 at 10:49:10PM +0530, Koul, Vinod wrote:
> @@ -1870,6 +1868,10 @@ static int soc_probe(struct platform_device *pdev)
> struct snd_soc_card *card = platform_get_drvdata(pdev);
> int ret = 0;
>
> + /* no card, so machine driver is registering card */
> + if (!card)
> + return 0;
> +
I'll review this one more closely tomorrow - as I said with the combined
patch I'd not expect the soc-audio device to be involved when the
machine driver is registering a card so I'd like to understand in more
detail why this is still required.
next prev parent reply other threads:[~2011-01-13 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 17:19 [PATCH 4/4] ASoC: soc core allow machine driver to register the card Koul, Vinod
2011-01-13 23:41 ` Mark Brown [this message]
2011-01-14 0:17 ` ALSA driver fails to creat ControlC1 and others Philip Chu
2011-01-14 8:31 ` Takashi Iwai
2011-01-18 16:37 ` Philip Chu
2011-01-14 4:24 ` [PATCH 4/4] ASoC: soc core allow machine driver to register the card Koul, Vinod
2011-01-14 10:52 ` Mark Brown
2011-01-14 11:25 ` Koul, Vinod
2011-01-14 11:37 ` Mark Brown
2011-01-14 13:52 ` Koul, Vinod
-- strict thread matches above, loose matches on Subject: below --
2011-01-14 13:52 Koul, Vinod
2011-01-17 13:45 ` Liam Girdwood
2011-01-17 13:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113234135.GD13717@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=harsha.priya@intel.com \
--cc=lrg@slimlogic.co.uk \
--cc=selma.bensaid@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.