From: Chris Ball <cjb@laptop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mmc@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: drivers/mmc/host/sdhci-of-core.c on sparc64
Date: Fri, 14 Jan 2011 01:12:13 +0000 [thread overview]
Message-ID: <20110114011212.GA22374@void.printf.net> (raw)
In-Reply-To: <20110113154140.7176df4c.akpm@linux-foundation.org>
Hi,
On Thu, Jan 13, 2011 at 03:41:40PM -0800, Andrew Morton wrote:
> > > drivers/mmc/host/sdhci-of-core.c:24:25: asm/machdep.h: No such file or directory
> > > drivers/mmc/host/sdhci-of-core.c: In function `sdhci_of_wp_inverted':
> > > drivers/mmc/host/sdhci-of-core.c:115: error: implicit declaration of function `machine_is'
> > >
> > > That code's been there for a while. Did someone change Kconfig?
> >
> > Can you attach a .config? <asm/machdep.h> is arch-specific, so I'd
> > suggest that you're building on an unsupported arch.
> >
>
> sparc64 allmodconfig.
You're right, Andrew -- Rob (CC'd) changed the MMC Kconfig to build this
driver on Sparc. Mainline commit 236cdc7bc71 ("of: make drivers depend
on CONFIG_OF instead of CONFIG_PPC_OF").
Rob also posted a patch to devicetree-discuss@, on top of the one above
("mmc: sdhci-of: fix build on non-powerpc platforms"), to fix up the
Sparc build by ifdef'ing for PPC inside the driver. Grant merged the
first patch but not the second, hence sparc64 allmodconfig is broken
now. The reason Grant didn't merge the second patch may be that Wolfram
objected to #ifdef proliferation inside the driver.
Options, as I see it:
* revert the commit such that MMC_SDHCI_OF once again depends on PPC_OF
* take the second patch as-is
* come up with a less-#ifdeffy second patch
Wolfram, would appreciate your input on what we should do here. Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-14 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 23:10 drivers/mmc/host/sdhci-of-core.c on sparc64 Andrew Morton
2011-01-13 23:38 ` Chris Ball
2011-01-13 23:41 ` Andrew Morton
2011-01-14 1:12 ` Chris Ball [this message]
2011-01-14 7:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114011212.GA22374@void.printf.net \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.