[PATCH] staging: smbfs building fix

[PATCH] staging: smbfs building fix

[Yang Ruirui]

Building error for smbfs:

drivers/staging/smbfs/dir.c:286: error: static declaration of 'smbfs_dentry_operations' follows non-static declaration
drivers/staging/smbfs/proto.h:42: error: previous declaration of 'smbfs_dentry_operations' was here
drivers/staging/smbfs/dir.c:294: error: static declaration of 'smbfs_dentry_operations_case' follows non-static declaration
drivers/staging/smbfs/proto.h:41: error: previous declaration of 'smbfs_dentry_operations_case' was here
make[3]: *** [drivers/staging/smbfs/dir.o] Error 1
make[2]: *** [drivers/staging/smbfs] Error 2
make[1]: *** [drivers/staging] Error 2
make[1]: *** Waiting for unfinished jobs....

Fix it by removing static keywords

Signed-off-by: Yang Ruirui <ruirui.r.yang@tieto.com>
---
 drivers/staging/smbfs/dir.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.orig/drivers/staging/smbfs/dir.c	2011-01-14 14:37:19.000000000 +0800
+++ linux-2.6/drivers/staging/smbfs/dir.c	2011-01-14 15:35:41.756037133 +0800
@@ -283,7 +283,7 @@ static int smb_compare_dentry(const stru
 		unsigned int, const char *, const struct qstr *);
 static int smb_delete_dentry(const struct dentry *);
 
-static const struct dentry_operations smbfs_dentry_operations =
+const struct dentry_operations smbfs_dentry_operations =
 {
 	.d_revalidate	= smb_lookup_validate,
 	.d_hash		= smb_hash_dentry,
@@ -291,7 +291,7 @@ static const struct dentry_operations sm
 	.d_delete	= smb_delete_dentry,
 };
 
-static const struct dentry_operations smbfs_dentry_operations_case =
+const struct dentry_operations smbfs_dentry_operations_case =
 {
 	.d_revalidate	= smb_lookup_validate,
 	.d_delete	= smb_delete_dentry,

Re: [PATCH] staging: smbfs building fix

[Nick Piggin]

On Fri, Jan 14, 2011 at 6:51 PM, Yang Ruirui <ruirui.r.yang@tieto.com> wrote:
> Building error for smbfs:
>
> drivers/staging/smbfs/dir.c:286: error: static declaration of 'smbfs_dentry_operations' follows non-static declaration
> drivers/staging/smbfs/proto.h:42: error: previous declaration of 'smbfs_dentry_operations' was here
> drivers/staging/smbfs/dir.c:294: error: static declaration of 'smbfs_dentry_operations_case' follows non-static declaration
> drivers/staging/smbfs/proto.h:41: error: previous declaration of 'smbfs_dentry_operations_case' was here
> make[3]: *** [drivers/staging/smbfs/dir.o] Error 1
> make[2]: *** [drivers/staging/smbfs] Error 2
> make[1]: *** [drivers/staging] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> Fix it by removing static keywords

Thanks. It's a pain to find the options to compile the staging filesystems...