All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] freetype: fix for multilib toolchain
Date: Fri, 14 Jan 2011 09:11:29 +0100	[thread overview]
Message-ID: <20110114091129.13d810c8@surf> (raw)
In-Reply-To: <BAY145-w16379D55CDD8378B320C74C2F30@phx.gbl>

Hello Matt,

On Thu, 13 Jan 2011 21:18:33 -0700
Matt Johnson <mj1856@hotmail.com> wrote:

> FreeType's makefile needs to have the architecture (example, -march=armv4t) passed in the LDFLAGS in order to work properly with a multilib toolchain, like CodeSourcery.  This is the easiest way I could think of to do it.  Tested and works.

The description of your patch should be wrapped at ~80 columns.

> Signed-off-by: Matt Johnson <mj1856@hotmail.com>
> ---
>  package/freetype/freetype.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk
> index ad4292f..7e59b57 100644
> --- a/package/freetype/freetype.mk
> +++ b/package/freetype/freetype.mk
> @@ -8,6 +8,7 @@ FREETYPE_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/
>  FREETYPE_SOURCE = freetype-$(FREETYPE_VERSION).tar.bz2
>  FREETYPE_INSTALL_STAGING = YES
>  FREETYPE_INSTALL_TARGET = YES
> +FREETYPE_CONF_ENV = LDFLAGS="-march=$(CC_TARGET_ARCH_) $(TARGET_LDFLAGS)"

I am not sure I want to see this fixed this way. It looks like the
issue reported by Divick Kishore on sshd is similar: we need to pass
the -march argument in the LDFLAGS for all packages.

So probably we should rather adjust TARGET_LDFLAGS globally (its
definition is in package/Makefile.in) so that it contains the
appropriate -march.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-01-14  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14  4:18 [Buildroot] freetype: fix for multilib toolchain Matt Johnson
2011-01-14  8:11 ` Thomas Petazzoni [this message]
2011-01-14 12:47   ` Bjørn Forsman
2011-01-14 13:31     ` Michael S. Zick
2011-01-14 14:42       ` Thomas Petazzoni
2011-01-14 14:44     ` Thomas Petazzoni
2011-01-14 15:40       ` Michael S. Zick
2011-01-14 16:04       ` Matt Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110114091129.13d810c8@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.