From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] rubix: pass target cflags
Date: Fri, 14 Jan 2011 09:19:52 +0100 [thread overview]
Message-ID: <20110114091952.154e11e6@surf> (raw)
In-Reply-To: <BAY145-w120285E8572BD44A195EABC2F30@phx.gbl>
Matt,
On Thu, 13 Jan 2011 21:21:59 -0700
Matt Johnson <mj1856@hotmail.com> wrote:
> -RUBIX_MAKE_OPT = CC="$(TARGET_CC)" XINC="-I$(STAGING_DIR)/usr/include/X11" XLIB="-L$(STAGING_DIR)/usr/lib -lX11"
> +RUBIX_MAKE_OPT = CC="$(TARGET_CC) $(TARGET_CFLAGS)" XINC="-I$(STAGING_DIR)/usr/include/X11" XLIB="-L$(STAGING_DIR)/usr/lib -lX11"
I was wondering why passing all those flags was necessary with an
autotools-based package.
And in fact, rubix is not autotools based. The ./configure script
contains:
=================================================================
#!/bin/sh
echo "Dummy configure script for autotools in buildroot"
exit 0
=================================================================
So I would prefer to see this package converted to the GENTARGETS
infrastructure. This should be relatively simple:
* Remove RUBIX_INSTALL_STAGING, RUBIX_INSTALL_TARGET,
RUBIX_INSTALL_TARGET_OPT, RUBIX_MAKE_OPT
* Add the following lines
define RUBIX_BUILD_CMDS
$(MAKE) \
CC="$(TARGET_CC) $(TARGET_CFLAGS)" \
XINC="-I$(STAGING_DIR)/usr/include/X11" \
XLIB="-L$(STAGING_DIR)/usr/lib -lX11" \
-C $(@D)
endef
define RUBIX_INSTALL_TARGET_CMDS
$(MAKE) GAMESDIR=$(TARGET_DIR)/usr/games -C $(@D) install
endef
* Replace AUTOTARGETS by GENTARGETS
And if you have time, it would be even better to switch to the upstream
version instead of this version on avr32linux.org. There is a new
version 1.0.6 available, that you can grab from
http://sed.free.fr/rubix/index.html.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-01-14 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 4:21 [Buildroot] rubix: pass target cflags Matt Johnson
2011-01-14 8:19 ` Thomas Petazzoni [this message]
2011-01-14 15:38 ` Matt Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114091952.154e11e6@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.