From mboxrd@z Thu Jan  1 00:00:00 1970
From: Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH 1/2] make the feature checks in ->fallocate future proof
Date: Fri, 14 Jan 2011 08:05:16 -0500
Message-ID: <20110114130515.GA2558@localhost.localdomain>
References: <20110114120730.GA13936@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, josef@redhat.com,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:19528 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757119Ab1ANNFZ (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 14 Jan 2011 08:05:25 -0500
Content-Disposition: inline
In-Reply-To: <20110114120730.GA13936@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jan 14, 2011 at 01:07:30PM +0100, Christoph Hellwig wrote:
> Instead of various home grown checks that might need updates for new
> flags just check for any bit outside the mask of the features supported
> by the filesystem.  This makes the check future proof for any newly
> added flag.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 

Reviewed-by: Josef Bacik <josef@redhat.com>

Thanks,

Josef