From: Seth Forshee <seth.forshee@canonical.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Matthew Garrett <mjg@redhat.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] thinkpad_acpi: Always report scancodes for hotkeys
Date: Fri, 14 Jan 2011 16:56:38 -0600 [thread overview]
Message-ID: <20110114225638.GA2060@thinkpad-t410> (raw)
In-Reply-To: <20110114222517.GA11207@khazad-dum.debian.net>
On Fri, Jan 14, 2011 at 08:25:17PM -0200, Henrique de Moraes Holschuh wrote:
> On Fri, 14 Jan 2011, Seth Forshee wrote:
> > Some thinkpad hotkeys report key codes like KEY_FN_F8 when something
> > like KEY_VOLUMEDOWN is desired. Always provide the scan codes in
> > addition to the key codes to assist with debugging these issues. Also
> > send the scan code before the key code to match what other drivers do,
> > as some userspace utilities expect this ordering.
>
> Do I have your word of honour that canonical is not going to start using
> scancodes instead of keycodes in Ubuntu to trigger actions?
That would be silly. The reason for this change is to aid in collecting
the data to update udev's keymaps for non-standard keys (see [1]). udev
uses the EVIOCSKEYCODE ioctl to associate the correct key code with the
scan codes. We don't intend to use scan codes instead of key codes.
[1] http://git.kernel.org/?p=linux/hotplug/udev.git;a=blob;f=extras/keymap/README.keymap.txt;hb=HEAD
next prev parent reply other threads:[~2011-01-14 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 21:54 [PATCH] thinkpad_acpi: Always report scancodes for hotkeys Seth Forshee
2011-01-14 22:25 ` Henrique de Moraes Holschuh
2011-01-14 22:56 ` Seth Forshee [this message]
2011-01-15 2:13 ` Henrique de Moraes Holschuh
2011-02-21 20:46 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114225638.GA2060@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.