diff for duplicates of <20110115140445.GD2721@bicker> diff --git a/a/1.txt b/N1/1.txt index d51b8b3..a933351 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ The signed one-bit types can be 0 or -1 which can cause a problem if -someone ever checks if (foo->lu_gp_assoc = 1). The current code is +someone ever checks if (foo->lu_gp_assoc == 1). The current code is fine because everyone just checks zero vs non-zero. But Sparse complains about it so lets change it. The warnings look like this: diff --git a/a/content_digest b/N1/content_digest index bdcc036..287fd68 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[patch] [SCSI] target: dubious one-bit signed bitfield\0" - "Date\0Sat, 15 Jan 2011 14:04:45 +0000\0" + "Date\0Sat, 15 Jan 2011 17:04:45 +0300\0" "To\0Nicholas A. Bellinger <nab@linux-iscsi.org>\0" "Cc\0James Bottomley <James.Bottomley@suse.de>" linux-kernel@vger.kernel.org @@ -9,7 +9,7 @@ "\00:1\0" "b\0" "The signed one-bit types can be 0 or -1 which can cause a problem if\n" - "someone ever checks if (foo->lu_gp_assoc = 1). The current code is\n" + "someone ever checks if (foo->lu_gp_assoc == 1). The current code is\n" "fine because everyone just checks zero vs non-zero. But Sparse\n" "complains about it so lets change it. The warnings look like this:\n" "\n" @@ -98,4 +98,4 @@ " \tu8 (*get_fabric_proto_ident)(struct se_portal_group *);\n" " \tchar *(*tpg_get_wwn)(struct se_portal_group *);" -f8b612ec7ba646631b0bf03e4e92f164d93eb62c24a736132ba89c6d7545f706 +0ab611e6c460b81ea4a795899ad7f4a7dcc0c4fce7038c1f43e7374db0cf7f22
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.