diff for duplicates of <20110115165401.GE2721@bicker> diff --git a/a/1.txt b/N1/1.txt index b239067..ab11d25 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ On Sat, Jan 15, 2011 at 05:36:11PM +0100, walter harms wrote: > > Am 15.01.2011 15:04, schrieb Dan Carpenter: > > The signed one-bit types can be 0 or -1 which can cause a problem if -> > someone ever checks if (foo->lu_gp_assoc = 1). The current code is +> > someone ever checks if (foo->lu_gp_assoc == 1). The current code is > > fine because everyone just checks zero vs non-zero. But Sparse > > complains about it so lets change it. The warnings look like this: > > diff --git a/a/content_digest b/N1/content_digest index 09ae201..a28bd73 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\04D31CCFB.1060504@bfs.de\0" "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [patch] [SCSI] target: dubious one-bit signed bitfield\0" - "Date\0Sat, 15 Jan 2011 16:54:01 +0000\0" + "Date\0Sat, 15 Jan 2011 19:54:01 +0300\0" "To\0walter harms <wharms@bfs.de>\0" "Cc\0Nicholas A. Bellinger <nab@linux-iscsi.org>" James Bottomley <James.Bottomley@suse.de> @@ -16,7 +16,7 @@ "> \n" "> Am 15.01.2011 15:04, schrieb Dan Carpenter:\n" "> > The signed one-bit types can be 0 or -1 which can cause a problem if\n" - "> > someone ever checks if (foo->lu_gp_assoc = 1). The current code is\n" + "> > someone ever checks if (foo->lu_gp_assoc == 1). The current code is\n" "> > fine because everyone just checks zero vs non-zero. But Sparse\n" "> > complains about it so lets change it. The warnings look like this:\n" "> > \n" @@ -30,4 +30,4 @@ "regards,\n" dan carpenter -7e67ea09de676481c90c62cce663e02ae45f78151cd74003a8cb02c14c8676a7 +93f326ec4a529eef285c50705a609c648913fd81b04d5e18b6696a646a29eff4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.