From: Dan Carpenter <error27@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: question about smatch error
Date: Mon, 17 Jan 2011 09:06:01 +0300 [thread overview]
Message-ID: <20110117060601.GH2721@bicker> (raw)
In-Reply-To: <adar5ccyver.fsf@cisco.com>
On Sun, Jan 16, 2011 at 09:02:52PM -0800, Roland Dreier wrote:
> where eui is a u8*, and I don't see how smatch even thinks it knows how
> big the buffer is in the first place.
>
It comes from the memcpy:
memcpy(eui, dev->dev_addr, 3);
memcpy(eui + 5, dev->dev_addr + 3, 3);
The first line means smatch thinks "eui" is a 3 char buffer. The second
line gets ignored but normally smatch would see "eui + 5" as a separate
buffer.
Really when it sees the memcpy() that's just a guess about the size,
I'll disable it by default unless you use the --spammy option.
regards,
dan carpenter
prev parent reply other threads:[~2011-01-17 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 5:02 question about smatch error Roland Dreier
2011-01-17 5:33 ` David Miller
2011-01-17 6:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117060601.GH2721@bicker \
--to=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.