All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] param: add null statement to compiled-in module params
Date: Mon, 17 Jan 2011 10:11:15 +1030	[thread overview]
Message-ID: <201101171011.16182.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1294230424-4089-1-git-send-email-linus.walleij@stericsson.com>

On Wed, 5 Jan 2011 10:57:04 pm Linus Walleij wrote:
> Add an unused struct declaration statement requiring a
> terminating semicolon to the compile-in case to provoke an
> error if __MODULE_INFO() is used without the terminating
> semicolon. Previously MODULE_ALIAS("foo") (no semicolon)
> compiled fine if MODULE was not selected.

I really prefer the other way; make everyone use a semicolon.

Let's look how many we're talking about... hmm, I'm having
trouble finding any!

Could you patch this the other way, to make MODULE_ALIAS w/o a
semicolon always an error?

Thanks,
Rusty.

  reply	other threads:[~2011-01-16 23:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05 12:27 [PATCH] param: add null statement to compiled-in module params Linus Walleij
2011-01-16 23:41 ` Rusty Russell [this message]
2011-01-17  8:12   ` Linus Walleij
2011-01-18  1:09     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101171011.16182.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=error27@gmail.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.