From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] hotplug: allow hardlinked files for block
	device images
Date: Mon, 17 Jan 2011 16:57:12 +0100
Message-ID: <20110117155712.GA14939@aepfle.de>
References: <20101126135555.GA27483@aepfle.de>
 <4D3464B3.4050200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4D3464B3.4050200@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: xen-devel@lists.xensource.com, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jan 17, Paolo Bonzini wrote:

> Isn't this incorrect in case ${file} contains a character that is a
> regex escape (e.g. a star or backslash)?

I'm sure there are pathnames which break the regex in some way.
Adding an escape for '@' could be added, for example.

How well can the rest of Xen cope with odd filenames? In other words,
does it even get there if the configured pathnames have odd chars in it?

Olaf