From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Alessandro Zummo <a.zummo@towertech.it>,
Kyungmin Park <kyungmin.park@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Lukasz Majewski <l.majewski@samsung.com>,
myungjoo.ham@gmail.com
Subject: Re: [PATCH v5] MFD MAX8998/LP3974: Support Charger
Date: Tue, 18 Jan 2011 11:37:10 +0000 [thread overview]
Message-ID: <20110118113709.GD26498@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1294982579-10404-1-git-send-email-myungjoo.ham@samsung.com>
On Fri, Jan 14, 2011 at 02:22:59PM +0900, MyungJoo Ham wrote:
> With the new regulator, "CHARGER", users can control charging
> current and turn on and off the charger. Note that the charger
> specification of LP3974 is different from that of MAX8998.
>
> driver/power/max8998.c supports power supply APIs for
>
> 1. "ONLINE" monitors the charger status, which can be
> different from the status "CHARGER"; e.g., users allowed the charger
> to charge, but the MAX8998 chip decided not to do so.
>
> 2. "PRESENT" monitors the battery status (the existence of the
> battery).
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
My major concern here is still that the regulator and power drivers
aren't connected at all - it feels like either the regulator driver is
redundant or the power driver ought to be a consumer of the regulator
driver.
next prev parent reply other threads:[~2011-01-18 11:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 8:53 [PATCH v3 0/4] MFD MAX8998/LP3974 Driver Update MyungJoo Ham
2010-12-23 8:53 ` [PATCH v3 1/4] MFD MAX8998/LP3974: Support Hibernation MyungJoo Ham
2010-12-24 11:38 ` Samuel Ortiz
2010-12-23 8:53 ` [PATCH v3 2/4] MFD MAX8998/LP3974: Support LP3974 RTC MyungJoo Ham
2010-12-24 11:38 ` Samuel Ortiz
2011-01-04 5:17 ` [PATCH v4 0/3] MFD MAX8998/LP3974 Driver Update MyungJoo Ham
2011-01-04 5:17 ` [PATCH v4 1/3] MFD MAX8998/LP3974: Support LP3974 RTC MyungJoo Ham
2011-01-04 13:40 ` Mark Brown
2011-01-11 11:22 ` Samuel Ortiz
2011-01-04 5:17 ` [PATCH v4 2/3] regulator MAX8998/LP3974: Support DVS-GPIO MyungJoo Ham
2011-01-04 7:49 ` Lukasz Majewski
2011-01-04 8:16 ` MyungJoo Ham
2011-01-04 13:44 ` Mark Brown
2011-01-11 11:22 ` Samuel Ortiz
2011-01-04 5:17 ` [PATCH v4 3/3] MFD MAX8998/LP3974: Support Charger MyungJoo Ham
2011-01-04 13:56 ` Mark Brown
2011-01-05 0:43 ` MyungJoo Ham
2011-01-14 5:22 ` [PATCH v5] " MyungJoo Ham
2011-01-18 11:37 ` Mark Brown [this message]
2010-12-23 8:53 ` [PATCH v3 3/4] regulator MAX8998/LP3974: Support DVS-GPIO MyungJoo Ham
2010-12-24 11:36 ` Samuel Ortiz
2011-01-02 13:56 ` Mark Brown
2010-12-23 8:53 ` [PATCH v3 4/4] MFD MAX8998/LP3974: Support Charger MyungJoo Ham
2010-12-24 11:37 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118113709.GD26498@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=a.zummo@towertech.it \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.