From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46531 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfCWo-0006g2-5B
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 09:27:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PfCWn-0000JO-2S
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 09:27:22 -0500
Received: from mail-fx0-f45.google.com ([209.85.161.45]:44266)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PfCWm-0000JB-QK
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 09:27:21 -0500
Received: by fxm12 with SMTP id 12so7455441fxm.4
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 06:27:20 -0800 (PST)
Date: Tue, 18 Jan 2011 15:27:15 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Log instruction start in TCG code
Message-ID: <20110118142714.GD5414@edde.se.axis.com>
References: <1295356120-27039-1-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1295356120-27039-1-git-send-email-peter.maydell@linaro.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On Tue, Jan 18, 2011 at 01:08:40PM +0000, Peter Maydell wrote:
> Add support for logging the start of instructions in TCG
> code debug dumps for ARM targets.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Applied, thanks.


> ---
>  target-arm/translate.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 907d73a..c60cd18 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9199,6 +9199,10 @@ static inline void gen_intermediate_code_internal(CPUState *env,
>          if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO))
>              gen_io_start();
>  
> +        if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) {
> +            tcg_gen_debug_insn_start(dc->pc);
> +        }
> +
>          if (dc->thumb) {
>              disas_thumb_insn(env, dc);
>              if (dc->condexec_mask) {
> -- 
> 1.7.1
> 
>