From: Joel Becker <jlbec@evilplan.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
James Bottomley <James.Bottomley@suse.de>
Subject: Re: [PATCH] ocfs2: Make OCFS2_FS depend on CONFIGFS_FS
Date: Tue, 18 Jan 2011 23:09:36 +0000 [thread overview]
Message-ID: <20110118230936.GD13251@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1295133371-25990-4-git-send-email-nab@linux-iscsi.org>
On Sat, Jan 15, 2011 at 03:16:10PM -0800, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch fixes the following kconfig error after changing
> CONFIGFS_FS -> select SYSFS:
>
> fs/sysfs/Kconfig:1:error: recursive dependency detected!
> fs/sysfs/Kconfig:1: symbol SYSFS is selected by CONFIGFS_FS
> fs/configfs/Kconfig:1: symbol CONFIGFS_FS is selected by OCFS2_FS
> fs/ocfs2/Kconfig:1: symbol OCFS2_FS depends on SYSFS
<snip>
> diff --git a/fs/ocfs2/Kconfig b/fs/ocfs2/Kconfig
> index ab152c0..77a8de5 100644
> --- a/fs/ocfs2/Kconfig
> +++ b/fs/ocfs2/Kconfig
> @@ -1,7 +1,6 @@
> config OCFS2_FS
> tristate "OCFS2 file system support"
> - depends on NET && SYSFS
> - select CONFIGFS_FS
> + depends on NET && SYSFS && CONFIGFS_FS
Isn't this exactly what Linus just said not to do? I don't want
to know that I need to select configfs. Shouldn't it instead just be:
select NET
select CONFIGFS_FS
Linus?
Joel
--
next prev parent reply other threads:[~2011-01-18 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 23:16 [PATCH] Fix CONFIGFS_FS -> select SYSFS recursive dependencies Nicholas A. Bellinger
2011-01-15 23:16 ` [PATCH] net: Make NETCONSOLE_DYNAMIC depend on CONFIGFS_FS Nicholas A. Bellinger
2011-01-15 23:16 ` [PATCH] dlm: Make DLM " Nicholas A. Bellinger
2011-01-15 23:16 ` [PATCH] ocfs2: Make OCFS2_FS " Nicholas A. Bellinger
2011-01-18 23:09 ` Joel Becker [this message]
2011-01-18 23:39 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118230936.GD13251@ZenIV.linux.org.uk \
--to=jlbec@evilplan.org \
--cc=James.Bottomley@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.