From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Do not copy elf section to same adress
Date: Wed, 19 Jan 2011 09:40:28 +0100 [thread overview]
Message-ID: <20110119084028.35BBE2FC@gemini.denx.de> (raw)
In-Reply-To: <1295367283-4696-1-git-send-email-weisserm@arcor.de>
Dear Matthias Weisser,
In message <1295367283-4696-1-git-send-email-weisserm@arcor.de> you wrote:
> When an elf section is already at the right position (e.g. after image
> decompression by bootm) there is no need to copy it.
>
> Signed-off-by: Matthias Weisser <weisserm@arcor.de>
> ---
> common/cmd_elf.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/common/cmd_elf.c b/common/cmd_elf.c
> index bf32612..aec4579 100644
> --- a/common/cmd_elf.c
> +++ b/common/cmd_elf.c
> @@ -342,9 +342,10 @@ static unsigned long load_elf_image_shdr(unsigned long addr)
> memset ((void *)shdr->sh_addr, 0, shdr->sh_size);
> } else {
> image = (unsigned char *) addr + shdr->sh_offset;
> - memcpy ((void *) shdr->sh_addr,
> - (const void *) image,
> - shdr->sh_size);
> + if ((void *) shdr->sh_addr != (void *) image)
> + memcpy((void *) shdr->sh_addr,
> + (const void *) image,
> + shdr->sh_size);
Braces required for multi-line statement.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Egotist: A person of low taste, more interested in himself than in
me. - Ambrose Bierce
next prev parent reply other threads:[~2011-01-19 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 16:14 [U-Boot] [PATCH] Do not copy elf section to same adress Matthias Weisser
2011-01-19 8:40 ` Wolfgang Denk [this message]
2011-01-19 11:03 ` [U-Boot] [PATCH V2] " Matthias Weisser
2011-04-11 16:17 ` Matthias Weisser
2011-04-11 19:59 ` Wolfgang Denk
2011-04-11 20:12 ` Matthias Weisser
2011-04-11 21:09 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119084028.35BBE2FC@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.